[AArch64][SVE] Share code across SVE prologue/epilogue implementations (NFCI) #162253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdesmalen-arm
approved these changes
Oct 7, 2025
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
…s (NFCI) (#162253) This patch refactors the SVE prologue and epilogue to use a common code path for both the "Default" and "Split" SVE layouts. This also factors some code into common helpers, such as: - `partitionSVECS()` (which returns the MI ranges of the PPR/ZPR callee-saves) - `getSVEStackFrameSizes()` (which returns the sizes of the PPR/ZPR locals/callee-saves) Since most split-SVE layout code is now shared with the default path, there should be much less code that is only tested when split-SVE is enabled.
clingfei
pushed a commit
to clingfei/llvm-project
that referenced
this pull request
Oct 10, 2025
…s (NFCI) (llvm#162253) This patch refactors the SVE prologue and epilogue to use a common code path for both the "Default" and "Split" SVE layouts. This also factors some code into common helpers, such as: - `partitionSVECS()` (which returns the MI ranges of the PPR/ZPR callee-saves) - `getSVEStackFrameSizes()` (which returns the sizes of the PPR/ZPR locals/callee-saves) Since most split-SVE layout code is now shared with the default path, there should be much less code that is only tested when split-SVE is enabled.
DharuniRAcharya
pushed a commit
to DharuniRAcharya/llvm-project
that referenced
this pull request
Oct 13, 2025
…s (NFCI) (llvm#162253) This patch refactors the SVE prologue and epilogue to use a common code path for both the "Default" and "Split" SVE layouts. This also factors some code into common helpers, such as: - `partitionSVECS()` (which returns the MI ranges of the PPR/ZPR callee-saves) - `getSVEStackFrameSizes()` (which returns the sizes of the PPR/ZPR locals/callee-saves) Since most split-SVE layout code is now shared with the default path, there should be much less code that is only tested when split-SVE is enabled.
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
…s (NFCI) (llvm#162253) This patch refactors the SVE prologue and epilogue to use a common code path for both the "Default" and "Split" SVE layouts. This also factors some code into common helpers, such as: - `partitionSVECS()` (which returns the MI ranges of the PPR/ZPR callee-saves) - `getSVEStackFrameSizes()` (which returns the sizes of the PPR/ZPR locals/callee-saves) Since most split-SVE layout code is now shared with the default path, there should be much less code that is only tested when split-SVE is enabled.
MacDue
added a commit
to MacDue/llvm-project
that referenced
this pull request
Oct 16, 2025
This was left out of the original patch (llvm#142392) to simplify the initial implementation. However, after refactoring the SVE prologue/epilogue code in llvm#162253, it's not much of an extension to support this case. The main change here is when restoring the SP from the FP for the SVE restores, we may need an additional frame offset to move from the start of the ZPR callee-saves to the start of the PPR callee-saves. This patch also fixes a previously latent bug where we'd add the `RealignmentPadding` when allocating the PPR locals, then again for the ZPR locals. This was unnecessary as the stack only needs to be realigned after all SVE allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the SVE prologue and epilogue to use a common code path for both the "Default" and "Split" SVE layouts.
This also factors some code into common helpers, such as:
partitionSVECS()(which returns the MI ranges of the PPR/ZPR callee-saves)getSVEStackFrameSizes()(which returns the sizes of the PPR/ZPR locals/callee-saves)Since most split-SVE layout code is now shared with the default path, there should be much less code that is only tested when split-SVE is enabled.
This patch was prepared in a number of small steps (that should build alone). I've kept these as commits in the PR, as it may help with review.